Upgrade Gradle version to 9 #6471
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Motivation:
Athenz ZTS server defined in the Docker Compose file fails to start up
because of changes introduced in Athenz 1.12.28.
```java
WARN o.e.jetty.ee10.webapp.WebAppContext - Failed startup of context oeje10w.WebAppContext@79f227a9{zts,/zts,b=file:///tmp/jetty-0_0_0_0-8443-zts_war-_zts-any-1237552957018305555/webapp/,a=AVAILABLE,h=oeje10s.SessionHandler@14f3c6fc{STARTED}}{/opt/athenz/zts/webapps/zts.war}
jakarta.servlet.ServletException: zts-server==org.glassfish.jersey.servlet.ServletContainer@5aa3f717{jsp=null,order=1,inst=true,async=true,src=DESCRIPTOR:file:///tmp/jetty-0_0_0_0-8443-zts_war-_zts-any-1237552957018305555/webapp/WEB-INF/web.xml,STARTED}
...
Caused by: com.yahoo.athenz.auth.util.CryptoException: Invalid jwks uri: athenz-zts-server/oauth2/keys?rfc=true
at com.yahoo.athenz.auth.token.jwts.JwtsSigningKeyResolver.addKeySource(JwtsSigningKeyResolver.java:181)
at com.yahoo.athenz.auth.token.jwts.JwtsSigningKeyResolver.addJwksUriKeySource(JwtsSigningKeyResolver.java:140)
at com.yahoo.athenz.auth.token.jwts.JwtsSigningKeyResolver.createKeyResolver(JwtsSigningKeyResolver.java:135)
at com.yahoo.athenz.auth.token.jwts.JwtsSigningKeyResolver.<init>(JwtsSigningKeyResolver.java:92)
at com.yahoo.athenz.auth.token.jwts.JwtsHelper.getJWTProcessor(JwtsHelper.java:241)
at com.yahoo.athenz.zts.ZTSImpl.loadJWTProcessors(ZTSImpl.java:501)
at com.yahoo.athenz.zts.ZTSImpl.<init>(ZTSImpl.java:412)
at com.yahoo.athenz.zts.ZTSImpl.<init>(ZTSImpl.java:289)
at com.yahoo.athenz.zts.ZTSImplFactory.<clinit>(ZTSImplFactory.java:20)
... 75 common frames omitted
```
It seems that a valid jwks_url is required in zts.property to start the
server correctly. If it is not set, the system hostname is used instead,
which leads a `MalformedURLException`.
Modifications:
- Set `https://athenz.io` as a dummy oauth_issuer in zts.properties
- Use athenz/athenz-zts-db:latest for the base image of zts-db
- Using athenz-zms-db works by initializing it with `/zts-init-db.sql`,
but it’s not the intended value.
Result:
Revive broken Athenz tests
jrhee17
approved these changes
Nov 13, 2025
Contributor
jrhee17
left a comment
jrhee17
left a comment
There was a problem hiding this comment.
- With the upgrade, only
shadedTestis run now. This is likely the correct behavior and the build time has been cut to half thanks to this. - Checked that there are no significant changes in the uploaded build scans other than improved performance
- Checked there each changeset seems reasonable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Upgrading Gradle version to 9 is necessary to build and test Armeria on Java 25.
References:
Modifications:
cz.augi.gradle.scalafmtas the original plugin is no longer maintained.com.gradleup.shadow:com.gradleup.shadow.gradle.pluginas maintenance is tranferred to Gradleup. Future home/support for Shadow? GradleUp/shadow#908build/generated/sources/proto).generatedFilesBaseDiris no longer supported since 0.9.2 Emulate and deprecate generatedFilesBaseDir google/protobuf-gradle-plugin#636it/spring/boot2-tomcat8tests:it/thrift0.9.1test which didn't run before because of incorrect source location.Result:
Armeria can now be built with Gradle 9