Skip to content

Conversation

@ikhoon
Copy link
Contributor

@ikhoon ikhoon commented Oct 31, 2025

Motivation:

Please refer to #6420 for a detail explanation of the problem.

Modifications:

  • When ServiceRequestContext is pushed, no exception is thrown if the root() of the current ClientRequestContext is null, since it is not considered a context leak.

Result:

Motivation:

Please refer to line#6420 for a detail explanation of the problem.

Modifications:

- When `ServiceRequestContext` is pushed, no exception is thrown if the
  `root()` of the current `ClientRequestContext` is null, since it is
  not considered a context leak.

Result:

`RetryingClient` no longer raises a false-positive context leak error.
@ikhoon ikhoon added this to the 1.34.0 milestone Oct 31, 2025
@ikhoon ikhoon added the defect label Oct 31, 2025
Copy link
Contributor

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.10%. Comparing base (8150425) to head (f59a789).
⚠️ Report is 215 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6479      +/-   ##
============================================
- Coverage     74.46%   74.10%   -0.36%     
- Complexity    22234    22999     +765     
============================================
  Files          1963     2062      +99     
  Lines         82437    86130    +3693     
  Branches      10764    11311     +547     
============================================
+ Hits          61385    63826    +2441     
- Misses        15918    16888     +970     
- Partials       5134     5416     +282     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False-positive RequestContext leak warning when using RetryingClient

3 participants