Fix flaky InputStreamStreamMessageTest.emptyInputStream()
#6484
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Subscriber.onComplete()is invoked beforecompletionFutureis completed, so a happen-before relationship betweenbyteStreamMessage.isOpen()andSubscriber.onComplete()cannot be guaranteed.armeria/core/src/main/java/com/linecorp/armeria/common/stream/InputStreamStreamMessage.java
Lines 375 to 376 in 0d94d0d
Modifications:
.whenComplete().join()to explicitly wait untilInputStreamStreamMessagecompletes.Result:
Closes #6483