Introduce ConfigSourceLifecycleObserver
#6488
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
minwoox
approved these changes
Nov 17, 2025
| "Only envoyGrpc is supported for '%s'", configSource); | ||
| final EnvoyGrpc envoyGrpc = firstGrpcService.getEnvoyGrpc(); | ||
|
|
||
| final boolean ads = configSource.hasAds(); |
Contributor
There was a problem hiding this comment.
nit: we can move this to line 85.
|
|
||
| private MeterRegistry meterRegistry = Flags.meterRegistry(); | ||
| private MeterIdPrefix meterIdPrefix = DEFAULT_METER_ID_PREFIX; | ||
| private EventExecutor eventExecutor = DEFAULT_GROUP.next(); |
Contributor
There was a problem hiding this comment.
nit: what do you think ok creating DEFAULT_GROUP only when eventExecutor is not specified in the build method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This PR introduces
ConfigSourceLifecycleObserverwhich observes aConfigSourceClient.This may be useful when users would like to monitor the client which fetches xDS resources and can be as an equivalent of subscription statistics in envoy
ref: https://www.envoyproxy.io/docs/envoy/latest/configuration/overview/mgmt_server#xds-subscription-statistics
In order to allow users to select the
MeterRegistry/MeterIdPrefixaXdsBootstrapBuilderis introduced. While it is trivial to allow users to customize theConfigSourceLifecycleObserver, I don't think it's necessary at this stage and could be easily done later on if there is need for it.Modifications:
ConfigSourceLifecycleObserverand a default implementationDefaultConfigSourceLifecycleObserverConfigSourceLifecycleObservercallback methods are called fromSotwXdsStreamXdsBootstrapBuilderwhich allows users to customize theMeterRegistry,MeterIdPrefixEventExecutorused is dedicated for pushing xDS updates.Result:
ConfigSourceClientvia metrics