Simplify handling of branch names... #756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some predicted LOS and Android versions, so that future compiling is not hindered
use lineage numbers to split between legacy and new build instead of maintaining a list of branches
select branch and android version without maintaining a list
fix space between variable and equal sign
fix space between variable and equal sign
cleanup
cleanup
Replaced the part that may cause a globbing issue
Remove useless BRANCH_NUM variable.
|
OK. I'll merge this into my test branch despite the remianing shellcheck error, which I can fix in this test branch. I'll try and get the branch tested in the next few days. (I'm currently on vacation, and working on IodeOS builds when I have spare computer time). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...based on the code submitted in #755 , as described in #751 (comment)