Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result Demo of Sonar and Jit #7

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Result Demo of Sonar and Jit #7

wants to merge 25 commits into from

Conversation

EladKohavi
Copy link

workerB
workerB

Description

A clear and concise summary of the change and which issue (if any) it fixes. Should also include relevant motivation and context.

Resolved or fixed issue:

Affirmation

Copy link

@jit-ci jit-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Jit has detected 1 important finding in this PR that you should review.
The finding is detailed below as a comment.
It’s highly recommended that you fix this security issue before merge.

@@ -147,6 +147,8 @@
email: wurstbrot
username: wurstbrot
password: 'EinBelegtesBrotMitSchinkenSCHINKEN!'
totpSecret: IFTXE3SPOEYVURT2MRYGI52TKJ4HC3KH
key: timo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security control: Secret Detection

Type: Generic-Api-Key

Description: Generic API Key

Severity: HIGH


Jit Bot commands and options (e.g., ignore issue)

You can trigger Jit actions by commenting on this PR review:

  • #jit_ignore_fp Ignore and mark this specific single instance of finding as “False Positive”
  • #jit_ignore_accept Ignore and mark this specific single instance of finding as “Accept Risk”
  • #jit_undo_ignore Undo ignore command

@sonarcloud
Copy link

sonarcloud bot commented May 29, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@EladKohavi EladKohavi changed the title Demo of Sonar and Jit Result Demo of Sonar and Jit May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants