Implement cursor blinking in text editor #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xorgy
requested changes
Nov 7, 2024
|
And overall, remember to run |
tannal
force-pushed
the
vello-editor-blink
branch
from
ed532d2 to
1f8f726
Compare
tannal
force-pushed
the
vello-editor-blink
branch
from
1033e5e to
2659dc1
Compare
DJMcNab
reviewed
Nov 8, 2024
There was a problem hiding this comment.
I've not run this myself yet, but this will be good functionality to land. We could also point to #gpu > Rendering a blinking cursor
|
That's cool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented some kind of timer using
ControlFlow::WaitUntil.I believe the timer thing can be handled in a more general way, but I haven't figured it out yet.
blink.webm