Implement cursor blinking in text editor #152
Open
+40
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xorgy
requested changes
Nov 7, 2024
Comment on lines
+147
to
+148
| _ => {} | ||
| } |
| @@ -42,6 +42,10 @@ impl Editor { | |||
| self.editor.text() | |||
| } | |||
|
|
|||
| pub fn cursor_blink(&mut self) { | |||
| self.cursor_blink = !self.cursor_blink; | |||
There was a problem hiding this comment.
Might be better to handle this with a periodic function, instead of a toggle, but I won't block on this.
| @@ -300,10 +304,10 @@ impl Editor { | |||
| scene.fill(Fill::NonZero, transform, Color::STEEL_BLUE, None, &rect); | |||
| } | |||
| if let Some(cursor) = self.editor.selection_strong_geometry(1.5) { | |||
| scene.fill(Fill::NonZero, transform, Color::WHITE, None, &cursor); | |||
| scene.fill(Fill::NonZero, transform, if self.cursor_blink {Color::TRANSPARENT} else {Color::WHITE}, None, &cursor); | |||
There was a problem hiding this comment.
Since we're painting the whole scene regardless, might as well just add the condition around both of these if let Somes.
|
And overall, remember to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented some kind of timer using
ControlFlow::WaitUntil.I believe the timer thing can be handled in a more general way, but I haven't figured it out yet.
blink.webm