feat(vello_hybrid): Add clipping support for image rendering #1086
+191
−99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds clipping support for image rendering in
vello_hybrid
, allowing images to be correctly clipped by multiple nested clip layers.The x, y coordinates used for sampling depend on clip depth. If a strip is not in clipped space, it receives global strip view coordinates. Otherwise, it uses local slot coordinates, which results in incorrect image sampling — since sampling must occur relative to the global strip position. To address this, position data is now passed for all strips associated with image paints.
Additionally, the logic for determining whether to sample color from a solid rgba value, an image texture, or a slot texture has been refined. The flag used for this distinction was reduced from an 8-bit field to a 1-bit discriminator, enabling the
rgba_or_slot
field to be reused as apayload
across different paint modes.