Optimise the size of Vello (Classic) test snapshots using oxipng #1087
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size of these screenshots was the main reason we ended up using LFS for storing snapshots. These have now been reduced significantly by using
oxipng
, as in Vello Sparse Tests:This does not move us away from LFS. I think there are some reasonable arguments for doing that now (primarily to allow using jujitsu). But I'm not planning on pushing for that until we have another need for it.