[encoding] Do not allow zero-length buffer sizes#365
Merged
armansito merged 1 commit intolinebender:mainfrom Sep 21, 2023
Merged
[encoding] Do not allow zero-length buffer sizes#365armansito merged 1 commit intolinebender:mainfrom
armansito merged 1 commit intolinebender:mainfrom
Conversation
It is possible for a BufferSize of 0 bytes to trigger validation warnings as such buffers still need to get bound to their pipeline. The standard vello engine (src/engine.rs) handles this when a BufProxy is requested by setting the requested size to at least 16. This is now handled by the encoding crate by selecting a buffer size that can fit at least one element.
dfrg
approved these changes
Sep 21, 2023
Collaborator
dfrg
left a comment
dfrg
left a comment
There was a problem hiding this comment.
This has been a source of many problems so thanks for making it actually correct!
| // | ||
| // Note: not using `Ord::max` here because it doesn't support const eval yet (except | ||
| // in nightly) | ||
| len: if len > 0 { len } else { 1 }, |
Member
There was a problem hiding this comment.
Is that not the comment directly above?
Collaborator
There was a problem hiding this comment.
That’ll teach me to read comments. Please ignore :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible for a BufferSize of 0 bytes to trigger validation warnings as such buffers still need to get bound to their pipeline. The standard vello engine (src/engine.rs) handles this when a BufProxy is requested by setting the requested size to at least 16.
This is now handled by the encoding crate by selecting a buffer size that can fit at least one element.