-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mustExist flag to patch object #299
base: main
Are you sure you want to change the base?
Conversation
7ff6518
to
35f64e8
Compare
Where is the flag passed? What is its default value? |
On the
|
What will stop this flag breaking other implementations? |
So N3 patches would work as semaphores and Sparql Update patches would not -- the mime type would be the key? And Solid-ui code would have to switch to n3 patches immediately ? |
Who would change Gold? |
It is set to
N3 patches be able to specify a property
Correct.
Correct (but behavior for N3 is overridable with
They need to switch to N3 patches, as a correct implementation of SPARQL UPDATE does not have the semaphore behavior.
Maybe, it depends how they do their updates.
I'm afraid I cannot help with that—but do we have many instances running still? |
This PR is an alternative to #298.
Delete semantics are not changed by default. Instead, a patch flag
mustExist
is added; if that flag is set to a falsy value, then a DELETE with a non-matching WHERE clause will silently not cause any effect.Needed to address the incorrect SPARQL UPDATE semantics in nodeSolidServer/node-solid-server#1085.