Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A fix to accept headers not being sent correctly in the Fetcher #437

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

s-minoo
Copy link

@s-minoo s-minoo commented Aug 14, 2020

There are 3 fixes contained inside this PR.

  1. Added support for another proxy URL template where the proxy servers doesn't work with URL parameters. This is the case where the proxy server only works with the following template : http://proxy.com/{uri}. For example, https://proxy.linkeddatafragments.org/ does this.

  2. We also added support for sending proxy request from http instead of requiring https. Maybe this might not be necessary, but it was needed in our use case. It would be nice if we could add an option to use http instead.

  3. Accept headers weren't being sent correctly with the HTTP requests. Apparently, the problem lies in the Header interface from typescript where the specified accept types doesn't get parsed correctly. We fixed it by making use of native javascript Object.assign({}, header}. Hopefully it won't cause a security concern with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants