A fix to accept headers not being sent correctly in the Fetcher #437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 3 fixes contained inside this PR.
Added support for another proxy URL template where the proxy servers doesn't work with URL parameters. This is the case where the proxy server only works with the following template :
http://proxy.com/{uri}
. For example, https://proxy.linkeddatafragments.org/ does this.We also added support for sending proxy request from
http
instead of requiringhttps
. Maybe this might not be necessary, but it was needed in our use case. It would be nice if we could add an option to usehttp
instead.Accept headers weren't being sent correctly with the HTTP requests. Apparently, the problem lies in the
Header
interface from typescript where the specified accept types doesn't get parsed correctly. We fixed it by making use of native javascriptObject.assign({}, header}
. Hopefully it won't cause a security concern with the fix.