Skip to content

chore(core): more concise on build constraints #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mengzhuo wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −31
Open

chore(core): more concise on build constraints #831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions core/open_out_log_unix.go → core/open_out_log_dup2_unix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
//go:build !windows && !(linux && arm64) && !(linux && loong64)
// +build !windows
// +build !linux !arm64
// +build !linux !loong64
//go:build !arm64 && !loong64 && !riscv64
// +build !arm64,!loong64,!riscv64

// Copyright 2017 LinkedIn Corp. Licensed under the Apache License, Version
// 2.0 (the "License"); you may not use this file except in compliance with
Expand Down
7 changes: 3 additions & 4 deletions core/open_out_log_linux_dup3.go → core/open_out_log_dup3_unix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
//go:build linux && (arm64 || riscv64)
// +build linux
// +build arm64 riscv64
//go:build arm64 || riscv64 || loong64
// +build arm64 riscv64 loong64

// Copyright 2017 LinkedIn Corp. Licensed under the Apache License, Version
// 2.0 (the "License"); you may not use this file except in compliance with
Expand All @@ -17,7 +16,7 @@ import (
"syscall"
)

// linux_arm64 and linux_riscv64 doesn't have syscall.Dup2, so use
// linux/arm64, linux/riscv64, linux/loong64 doesn't have syscall.Dup2, so use
// the nearly identical syscall.Dup3 instead
func internalDup2(oldfd uintptr, newfd uintptr) error {
return syscall.Dup3(int(oldfd), int(newfd), 0)
Expand Down
23 changes: 0 additions & 23 deletions core/open_out_log_linux_loong64.go
View file
Open in desktop

This file was deleted.