Enable validating SqlCreateView and SqlCreateMaterializedView #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ValidationService
ryannedolan
approved these changes
May 29, 2025
| Files.writeString(servicesDir.resolve("com.linkedin.hoptimator.ValidatorProvider"), | ||
| "com.linkedin.hoptimator.jdbc.TestSqlScripts$CreateViewValidatorProvider\n"); | ||
|
|
||
| URLClassLoader cl = new URLClassLoader(new URL[]{tempDir.toUri().toURL()}, getClass().getClassLoader()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem and Solution
Currently HoptimatorDdlExecutor only do validation in a later stage against the planned deployable objects created from validates SqlCreateView and SqlCreateMaterializedView.
The ValidationService doesn't validate create view commands directly.
This PR is to make ValidationService validate create view commands early. No validators are registered for those commands by default. They can be extended by users of hoptimator-jdbc library.
Testing Done
Add new quidem test cases with a test validator to verify that create view commands are validated.