Fix mishandling of null types in output Avro schemas #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryannedolan
force-pushed
the
fix-null-types
branch
from
f5d00be to
78ced38
Compare
ryannedolan
force-pushed
the
fix-null-types
branch
from
78ced38 to
d089558
Compare
jogrogan
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Nested union: ["null",["null"]]bugDetails
Avro does not allow
["null",["null"]]nor["null", "null"].AvroConverterwas generating["null",["null"]], presumably in an attempt to represent a nullable null type. But of course the null type is implicitly nullable anyway.Testing
New unit test fails with
Nested union: ["null",["null"]]without the fix. Passes with the fix.