Fix resolve error caused by avro record collision #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryannedolan
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The !resolve endpoint attempts to pretty print the avro schema. At print time certain validations are made that fields are not redefined. In our current logic we were always using the same namespace but it is often the case where fields with the same name can exist under separate namespaces, with different record schemas.
This fix always assumes different namespaces for different record fields. It keeps the schema verbose but will solve any collision problems. Execution engines shouldn't actually care about the namespace
Also fixes an issue where there was no namespace attached to map and array fields.