Skip to content

Fix HF transformers Breaking Changes #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 20, 2025
Merged

Fix HF transformers Breaking Changes #526

merged 6 commits into from
Jan 20, 2025

Conversation

@austin362667
Copy link
Contributor

@austin362667 austin362667 commented Jan 16, 2025 •
edited
Loading

Summary

  1. Add a general version_dispatch utility function that selects constructors and its args based on version comparisons.
  2. Update LlamaRotaryEmbedding.

Closes Issue #525 and PR #523 (Thanks to @hebiao064's nice works).

Testing Done

  • Hardware Type:
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@austin362667
use LlamaConfig(head_dim)
460cfaf 
Signed-off-by: Austin Liu <[email protected]>
@austin362667
fix
83dcd59 
Signed-off-by: Austin Liu <[email protected]>
@austin362667
Copy link
Contributor Author

austin362667 commented Jan 16, 2025 •
edited
Loading

duplicate to #523

@austin362667 austin362667 changed the title Apply LlamaConfig(head_dim) Fix HF transformers Breaking Changes Jan 19, 2025
@austin362667 austin362667 reopened this Jan 19, 2025
@austin362667 austin362667 mentioned this pull request Jan 19, 2025
Closed
3 tasks
hebiao064
hebiao064 approved these changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@hebiao064 hebiao064 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for picking it up

@Tcc0403 Tcc0403 mentioned this pull request Jan 19, 2025
Closed
@austin362667 austin362667 merged commit a8fa3bb into main Jan 20, 2025
4 of 5 checks passed
@austin362667 austin362667 deleted the austin362667/fix_llama_rope branch January 20, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hebiao064 hebiao064 hebiao064 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@austin362667 @hebiao064