Skip to content

Fix visualization when data is from more than 1 gpu #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix visualization when data is from more than 1 gpu #938

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d2dabb
Fix visualization when data is from more than 1 gpu
Tcc0403 Nov 11, 2025
c0efd39
Format
Tcc0403 Nov 11, 2025
ca1e812
Merge branch 'main' into tcc/bench_vis
lancerts Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions benchmark/benchmarks_visualizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,14 @@ def load_data(config: VisualizationsConfig) -> pd.DataFrame:
print("Warning: Could not select an extra_benchmark_config. Using data from initial filter if any.")
final_filtered_df = base_filtered_df

# if gpu_filter:
gpu_grouped = final_filtered_df.groupby(["gpu_name"])

if len(gpu_grouped) > 1:
latest_gpu_name = list(gpu_grouped.groups.keys())[-1]
print(f"Collected data from more than 1 gpu. Picking the most recent data on {latest_gpu_name}")
final_filtered_df = gpu_grouped.get_group((latest_gpu_name,))

if final_filtered_df.empty:
raise ValueError(
f"No data found after attempting to filter by extra_benchmark_config. "
Expand Down