Add Ascend NPU device support. #955
Open
+88
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tcc0403
reviewed
Nov 27, 2025
Comment on lines
+81
to
+85
| try: | ||
| if hasattr(torch, "npu") and getattr(torch.npu, "amp", None) is not None: | ||
| return torch.npu.amp.custom_fwd, torch.npu.amp.custom_bwd | ||
| except Exception: | ||
| pass |
Collaborator
There was a problem hiding this comment.
What exception could it possibly be?
Comment on lines
+41
to
+48
| def get_npu_multi_processor_count() -> int: | ||
| """Return a heuristic multi-processor count for NPU.""" | ||
| NPU_MULTI_PROCESSOR_COUNT = 48 | ||
| if is_npu_available(): | ||
| return NPU_MULTI_PROCESSOR_COUNT | ||
| # Reasonable default to avoid division by zero | ||
| return 1 | ||
|
|
Collaborator
There was a problem hiding this comment.
Is torch.npu going to support get_device_properties so we can get these numbers programmatically? If that's the case, I suggest using that method instead and leave magic number as a fallback. WDYT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the first step in the adaptation of Ascend NPU to Liger Kernel: adding NPU device support. For details, refer to [RFC] Native Ascend NPU Support for Liger Kernel, Section 2.1: Device Support Integration.
Details
Key Modifications:
triton.language.mathon NPU to avoid errors caused by non-existent interfaces.Testing Done
Verification Status:
We have conducted verification on Atlas 800T A3, and basic test cases such as
test_softmaxandtest_swigluhave passed. We will continue to improve it in the future.make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence