-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coral-Spark: Migrate some operator transformers from RelNode layer to SqlNode layer #351
Coral-Spark: Migrate some operator transformers from RelNode layer to SqlNode layer #351
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coral-common/src/main/java/com/linkedin/coral/common/calcite/CalciteUtil.java
Outdated
Show resolved
Hide resolved
...on/src/main/java/com/linkedin/coral/common/transformers/OperatorBasedSqlCallTransformer.java
Outdated
Show resolved
Hide resolved
@wmoustafa: 2- Does it make sense to merge #349 first? 3- Could you see if you could reuse any of the transformers introduced in #349? |
104a68c
to
394979a
Compare
coral-hive/src/main/java/com/linkedin/coral/transformers/CoralRelToSqlNodeConverter.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @ljfgem
coral-hive/src/main/java/com/linkedin/coral/transformers/CoralRelToSqlNodeConverter.java
Show resolved
Hide resolved
coral-hive/src/main/java/com/linkedin/coral/transformers/CoralRelToSqlNodeConverter.java
Show resolved
Hide resolved
coral-hive/src/main/java/com/linkedin/coral/transformers/CoralRelToSqlNodeConverter.java
Outdated
Show resolved
Hide resolved
coral-hive/src/main/java/com/linkedin/coral/transformers/CoralRelToSqlNodeConverter.java
Outdated
Show resolved
Hide resolved
coral-spark/src/main/java/com/linkedin/coral/spark/CoralToSparkSqlCallConverter.java
Show resolved
Hide resolved
...-spark/src/main/java/com/linkedin/coral/spark/transformers/FallBackToHiveUDFTransformer.java
Outdated
Show resolved
Hide resolved
...l-spark/src/main/java/com/linkedin/coral/spark/transformers/TransportableUDFTransformer.java
Outdated
Show resolved
Hide resolved
coral-spark/src/main/java/com/linkedin/coral/spark/SparkSqlRewriter.java
Outdated
Show resolved
Hide resolved
coral-spark/src/main/java/com/linkedin/coral/spark/SparkSqlRewriter.java
Show resolved
Hide resolved
coral-hive/src/main/java/com/linkedin/coral/transformers/CoralRelToSqlNodeConverter.java
Show resolved
Hide resolved
cc26200
to
2c388fe
Compare
@aastha25 Thanks for your review! I have addressed all the comments and replied. |
Changes:
convertDaliUDF
,convertBuiltInUDF
andfallbackToHiveUdf
from RelNode layer in IRRelToSparkRelTransformer to SqlNode layer. We will migrate other remaining transformers and removeIRRelToSparkRelTransformer
afterwards.aliasContext
inCoralRelToSqlNodeConverter
to convert RelNode likef(x).y.z
to SqlNode which meets our expectation, check its comment for details.SparkSqlRewriter
to avoid casting to any type containingROW
given Spark doesn't allow that.Tests: