[Coral-Trino] Migrate SUBSTR() operator from RexShuttle to SqlShuttle #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request, and why are they necessary?
Prior to this PR, transformations required for Coral IR operator:
substr()to make it compatible with the Trino engine were performed in the RexShuttle,TrinoRexConverter. This PR migrates the transformation logic to a Sqlshuttle,DataTypeDerivedSqlCallConverteras part of a larger effort to make engine-specific transformations part of sqlCall transformations alone.This PR also registers 5 new Coral IR functions in the
StaticHiveFunctionRegistryto enable relDataType derivation of sqlCalls with these operators. Without these, the translations intestSubstrWithTimestampOperator()would fail.How was this patch tested?
./gradlew build
existing UTs and added new UTs
integration tests with production views