-
Notifications
You must be signed in to change notification settings - Fork 200
Add support for Integration test for Coral #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks Sumedh for the PR! Both |
Thanks Walaa. I did look at the tests in coral-trino and coral-spark, however, I was trying to create a test module where interoperability can be tested thoroughly. Hence the need for separate module. Also, the way things are setup, we need more flexibility in how we instantiate HMS for Hive (built-in is ok) v/s Iceberg (built-in is not ok). I think there is value in this kind of "uber" integration tests for interop testing, hence the addition. |
|
Can we unify things somehow? It is not clear to me when to use either side. Also there is a bunch of repeated code. |
Ack, I understand the concern about repeated code related to infra setup (Spark, HMS, Iceberg, etc.) and checking why standalone module for interoperability testing is key for a project like Coral. Here are some thoughts. We could position the tests as follows: It already has started to be effective for some of the test scenarios, https://github.com/sumedhsakdeo/coral/pull/1/files My worry is if I do bring setup module into coral-trino and coral-spark, I will likely be replicating a lot more of boiler plate code for Iceberg, HMS setup in both the modules. Also, I would rather lean on Mocking in individual modules, and full blown integration tests in this newly introduced module. Wdyt? |
What changes are proposed in this pull request, and why are they necessary?
This PR introduces a comprehensive integration testing infra for the Coral project that validates SQL translation capabilities across multiple query engines (Spark and Trino) with support for both Iceberg tables, and Hive tables / views.
It also adds sample test that can serve as a starter reference to add more tests to the repo and overall making the coral's interoperability story even more robust..
How was this patch tested?
The patch only adds tests to the coral repo.