Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve per task observability through additional logging #2204

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

allenxwang
Copy link
Contributor

@allenxwang allenxwang commented Oct 3, 2024

Summary

  1. Why:

We want to track and analyze task execution for each task in the log analysis tool. But currently there is not enough information logged and the log does not have task UUID so it is difficult to track on the per task base.

  1. What:

Added more INFO logging with UUID.

Also fixed a bug where null UUID is logged by moving the call to clearCompletedExecution() (where uuid is reset to null) to after the logging.

Additional evidence

Execution succeeded: task Id: null; removed brokers: [103986]; demoted brokers: null; total time used: 874448ms.. 

Categorization

  • documentation
  • [x ] bugfix
  • new feature
  • refactor
  • security/CVE
  • [ x] other

@allenxwang allenxwang changed the title Fix the issue that uuid is null in the log after execution Improve per task observability through additional logging Oct 4, 2024
Copy link
Contributor

@CCisGG CCisGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like are confusing "task" and "operation" here. In general, I think a task is a single partition reassignment, for example partition X: {broker A, B, C} -> {broker D, E, F}. An operation what CC executes to complete user request or self-healing. Broker removals or rebalances should be operations rather than task. So I think here you probably want to change them to "Operation id: {}"

Copy link
Contributor

@CCisGG CCisGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Allen!

@allenxwang allenxwang merged commit 6e45231 into main Oct 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants