Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Expected Behavior
When metric X is absent, Cruise Control should log a WARN message and continue planning using fallback metric values, without restarting or crashing.
Actual Behavior
Earlier, a NullPointerException occurred during partition load, causing the controller to restart and fail the planning process.
Steps to Reproduce
1.Use the config sample/configs/no-metric-x.properties.
2. Start Cruise Control with that config.
3. Run the workload generator or the provided repro script.
4. Observe the NullPointerException in the controller logs.
Known Workarounds
Re-enable metric X collection or use a fallback metric collector if one is configured.
Additional evidence
Environment
Cruise Control: v2.0.1
Java: 11.0.15
OS: Ubuntu 20.04
Kafka: 2.8.x
Added PartitionMetricLoaderTest::testMissingMetricFallback
Added integration test: integration-tests/missing_metric_x_repro.yaml
Benchmarks
No performance regressions observed in local runs.
Categorization
This PR resolves ##2333.