Skip to content

Disable L1 caching for pre-insertion retrieval #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Disable L1 caching for pre-insertion retrieval #265

wants to merge 1 commit into from

Conversation

@jphui
Copy link
Contributor

@jphui jphui commented May 30, 2023 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

<fix> : change Ebean retrieval to use QUERY level cache isolation

The default setting is Transaction which is (not likely but) possibly causing Ebean to retrieve wrong results.

This change is suggested here in response to a general question about disabling caching globally.

@yangyangv2 yangyangv2 self-requested a review May 31, 2023 12:24
yangyangv2
yangyangv2 reviewed May 31, 2023
View reviewed changes
@yangyangv2 yangyangv2 mentioned this pull request May 31, 2023
Merged
4 tasks
@jphui jphui force-pushed the jhui/disablecache branch from 8060e38 to ccd9b02 Compare June 6, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yangyangv2 yangyangv2 yangyangv2 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jphui @yangyangv2