Made nonDollarVirtualColumnsEnabled member of SQLSchemaUtils #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangyangv2
reviewed
Feb 16, 2024
Contributor
yangyangv2
left a comment
yangyangv2
left a comment
There was a problem hiding this comment.
This global static verifiable setting is unintuitive and error prone. Can we make the fix the ai-metadata-gms instead of including hack solution?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other GMS could have used the methods defined in SQLSchemaUtils. The last change to add
boolean nonDollarVirtualColumnsEnabledwill break those GMSes once they bump their version.I have made nonDollarVirtualColumnsEnabled a static member of SQLSchemaUtils which can be initialized when we create an instance of EbeanLocalAccess to set the value of nonDollarVirtualColumnsEnabled and be consistent with the whole instance.
Testing
./gradlew build
Checklist