Skip to content

Conversation

@rakhiagr
Copy link
Contributor

@rakhiagr rakhiagr commented Aug 12, 2025

Summary

This pull request introduces support for the HikariCP connection pool in the Ebean DAO implementation. The most significant changes are the addition of the HikariCP dependency and logic to handle HikariCP data sources when creating the schema evolution manager configuration.

Dependency management:

  • Added externalDependency.hikariCP to the dao-impl/ebean-dao/build.gradle dependencies to enable HikariCP support.

Schema evolution manager initialization:

  • Updated EbeanLocalAccess.java to import HikariDataSource for type checking and extraction of connection details.
  • Modified the createSchemaEvolutionManager method in EbeanLocalAccess.java to detect if the Ebean server is using a HikariCP data source and extract the JDBC URL, username, and password accordingly. Falls back to the existing logic if HikariCP is not used.

Testing Done

./gradlew build

Checklist

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.57%. Comparing base (1b4e026) to head (3dfed29).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...va/com/linkedin/metadata/dao/EbeanLocalAccess.java 53.84% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #570      +/-   ##
============================================
+ Coverage     64.56%   64.57%   +0.01%     
- Complexity     1657     1662       +5     
============================================
  Files           141      141              
  Lines          6555     6572      +17     
  Branches        801      805       +4     
============================================
+ Hits           4232     4244      +12     
- Misses         1978     1981       +3     
- Partials        345      347       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants