Refactor relationship table operations to be functional index compatible #590
+516
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphui
commented
Nov 21, 2025
Contributor
Author
There was a problem hiding this comment.
cannot mock at this level, everything is just passing new args in anyway so the testing is deferred to the callees :)
jphui
commented
Nov 26, 2025
Comment on lines
+90
to
+95
| @Nullable | ||
| public static String getIndexedExpressionOrColumn(@Nonnull String assetType, @Nonnull String aspect, @Nonnull String path, | ||
| boolean nonDollarVirtualColumnsEnabled, @Nonnull String tableName, @Nonnull SchemaValidatorUtil schemaValidator) { | ||
| final String expectedLegacyColumnName = getGeneratedColumnName(assetType, aspect, path, nonDollarVirtualColumnsEnabled); | ||
| return getIndexedExpressionOrColumnGeneric(expectedLegacyColumnName, getExpressionIndexName(assetType, aspect, path), tableName, schemaValidator); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Not tested directly in unit testing since the "inferred table variant" is tested thoroughly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
BUG=META-23290
This PR refactors relationship table operations to be aware of functional indexes (expression indexes) and will leverage them for queries if they exist, taking priority over any (virtual) column indexes.
Testing Done
unit testing thoroughly updated, will test this in EI as well
Checklist