Adding check for G1GC and modifying recommendation for enable G1GC or…

… ParallelGC
linkedin · Oct 14, 2018 · a080131 · a080131
1 parent 927c7c8
commit a080131
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/app/com/linkedin/drelephant/spark/heuristics/ExecutorGcHeuristic.scala b/app/com/linkedin/drelephant/spark/heuristics/ExecutorGcHeuristic.scala
@@ -104,8 +104,10 @@ object ExecutorGcHeuristic {
       throw new Exception("No executor information available.")
     }
 
-    val isParallelGCEnabled: Boolean = appConfigurationProperties.getOrElse("spark.executor.extraJavaOptions","").contains("XX:+UseParallelGC")
-    val parallelGcRecommendation: String = if (isParallelGCEnabled)  "" else "Enable ParallelGC using spark.executor.extraJavaOptions."
+    val sparkExecutorExtraJavaOptions = appConfigurationProperties.getOrElse("spark.executor.extraJavaOptions","")
+    val isParallelGCEnabled: Boolean = sparkExecutorExtraJavaOptions.contains("XX:+UseParallelGC")
+    val isG1GCenabled: Boolean = sparkExecutorExtraJavaOptions.contains("XX:+UseG1GC")
+    val gcRecommendation: String = if (isParallelGCEnabled || isG1GCenabled)  "" else "Enable ParallelGC or G1GC using spark.executor.extraJavaOptions."
 
     lazy val appConfigurationProperties: Map[String, String] =
       data.appConfigurationProperties

diff --git a/app/views/help/spark/helpExecutorGcHeuristic.scala.html b/app/views/help/spark/helpExecutorGcHeuristic.scala.html
@@ -19,7 +19,7 @@
 <h3>Suggestions</h3>
 <ul>
 <li>We recommend increasing the executor memory.</li>
-<li>Enabling ParallelGC using spark.executor.extraJavaOptions could help.</li>
+<li>Enabling G1GC or ParallelGC using spark.executor.extraJavaOptions could help.</li>
   <ul>
     <li>User can enable G1GC or ParallelGC by adding <b>-XX:+UseG1GC</b> or <b>-XX:+UseParallelGC</b> respectively to Spark configuration spark.executor.extraJavaOptions</li>
   </ul>