forked from apache/helix
-
Notifications
You must be signed in to change notification settings - Fork 4
Adding the sensors in DistClusterControllerStateModel #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vivek8420
wants to merge
31
commits into
dev
Choose a base branch
from
sensor-addition-dist-state-model
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "upgrade xstream to 1.4.20 to pick up fixes for 2 CVEs (apache#2763)" dep is banned internally
New Release Snapshot with several fixes: [apache/helix] -- Issue during onboarding resources without instances apache#2782 [apache/helix] -- Provide JDK 1.8 (backward) compatibility of helix-core apache#2775 Do not start the server if user uses the default SECRET_TOKEN env value apache#2783 Delete expected version apache#2759 [apache/helix] -- Fix PreferenceList Ordering Changes during Maintenance Mode apache#2778
…compat [Linkedin/Helix] -- Provide JDK 1.8 (backward) compatibility for meta-client
[Linkedin/Helix] -- Provide JDK 1.8 (backward) compatibility for helix modules
Release for helix 1.3.2-dev-202406121430
Release for helix 1.3.2-dev-202406131130
Merge `master` into `release`
Release for helix 1.4.3-dev-202412052251
Release for helix 1.4.3-dev-202502211050 Merge branch gspencer/release-20250221 into release branch
Release for Release for helix 1.4.3-dev-202505071400-hf-HELIX-5658
…sor-addition-dist-state-model
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/participant/DistClusterControllerStateModel.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/participant/DistClusterControllerStateModel.java
Outdated
Show resolved
Hide resolved
proud-parselmouth
approved these changes
Jul 23, 2025
Collaborator
proud-parselmouth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just made a minor comment
helix-core/src/main/java/org/apache/helix/participant/DistClusterControllerStateModel.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
(apache#200 - Link your issue number here: You can write "Fixes #XXX". Please use the proper keyword so that the issue gets closed automatically. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue
Any of the following keywords can be used: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved)
Description
(Write a concise description including what, why, how)
Tests
(List the names of added unit/integration tests)
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)