Allow Transition from UNKNOWN to EVACUATE #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| @Test(dataProvider = "selfTransitions") | ||
| public void testSelfTransitions(InstanceConstants.InstanceOperation state) { |
Collaborator
There was a problem hiding this comment.
Do we need this test? can we have the self-transitions as part of always_allowed transitions?
| } | ||
|
|
||
| @Test | ||
| public void testUnknownToEvacuateTransition() { |
Collaborator
There was a problem hiding this comment.
Isn't this covered in always_allowed transitions?
| } | ||
|
|
||
| @Test | ||
| public void testEvacuateToUnknownTransition() { |
Collaborator
There was a problem hiding this comment.
Same, this is also covered in always_allowed transitions
| * Tests all possible transitions between instance operation states to ensure proper | ||
| * validation logic and maintain backward compatibility. | ||
| */ | ||
| public class TestInstanceUtilTransitions { |
Collaborator
There was a problem hiding this comment.
Can we just have two tests, one for always_allowed, and another for invalid state transitions
| * These transitions should be rejected by the validation logic. | ||
| */ | ||
| @DataProvider | ||
| public Object[][] invalidTransitions() { |
Collaborator
There was a problem hiding this comment.
Is this list exhaustive?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
apache#3070
Description
Helix does not allow moving transition from UNKNOWN to EVACUATE
Tests
(List the names of added unit/integration tests)
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Unit Tested the change