Add ERROR partitions metric to Instance Monitor #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on health tracking
LZD-PratyushBhatt
changed the title
proud-parselmouth
approved these changes
Nov 24, 2025
Collaborator
proud-parselmouth
left a comment
proud-parselmouth
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the quick turn around on this
| Map<String, LiveInstance> liveInstanceMap = dataProvider.getLiveInstances(); | ||
| Map<String, Set<Message>> instanceMessageMap = Maps.newHashMap(); | ||
| Map<String, InstanceConfig> instanceConfigMap = dataProvider.getInstanceConfigMap(); | ||
| Map<String, Long> errorPartitionCounts = Maps.newHashMap(); |
Collaborator
There was a problem hiding this comment.
nit: change variable name to instanceErrorPartitionCounts
| try { | ||
| Map<String, LiveInstance> liveInstances = dataProvider.getLiveInstances(); | ||
| LiveInstance liveInstance = liveInstances.get(instanceName); | ||
|
|
Collaborator
There was a problem hiding this comment.
change the nested format to un nested format. For if liveInstance is not null, return errorCount.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Currently, there is no easy way to monitor how many partitions are in ERROR state on each participant instance, this makes troubleshooting and monitoring difficult.
(apache#200 - Link your issue number here: You can write "Fixes #XXX". Please use the proper keyword so that the issue gets closed automatically. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue
Any of the following keywords can be used: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved)
Description
(Write a concise description including what, why, how)
This PR introduces a new
ErrorPartitionsgauge metric in the Instance Monitor that tracks the number of partitions in ERROR state for each participant in real-time.Tests
New UTs added.
Tested manually in a Actual helix Cluster
(List the names of added unit/integration tests)
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)