Skip to content

Conversation

@simbadzina
Copy link

@simbadzina simbadzina commented Jan 28, 2025

Description

Shades jsonpath in regular shaded jar in addition to the shaded-all

Validation

Shaded jar before

x com/jayway/
x com/jayway/jsonpath/
x com/jayway/jsonpath/Configuration$1.class
x com/jayway/jsonpath/Configuration$ConfigurationBuilder.class
x com/jayway/jsonpath/Configuration$Defaults.class
x com/jayway/jsonpath/Configuration.class
x com/jayway/jsonpath/Criteria.class
x com/jayway/jsonpath/DocumentContext.class
...
...

Shaded jar after

x com/linkedin/coral/$internal/com/jayway/
x com/linkedin/coral/$internal/com/jayway/jsonpath/
x com/linkedin/coral/$internal/com/jayway/jsonpath/Configuration$1.class
x com/linkedin/coral/$internal/com/jayway/jsonpath/Configuration$ConfigurationBuilder.class
x com/linkedin/coral/$internal/com/jayway/jsonpath/Configuration$Defaults.class
x com/linkedin/coral/$internal/com/jayway/jsonpath/Configuration.class
x com/linkedin/coral/$internal/com/jayway/jsonpath/Criteria.class
x com/linkedin/coral/$internal/com/jayway/jsonpath/DocumentContext.class
...
...

Testing

Calcite builds successfully.

./mvnw clean install -Dgpg.skip -f core/pom.xml
...
...
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 08:48 min
[INFO] Finished at: 2025-01-30T13:32:34-08:00
[INFO] ------------------------------------------------------------------------

Coral builds successfully with local published calcite. All tests passed.

BUILD SUCCESSFUL in 3m 31s
560 actionable tasks: 560 executed

Copy link
Contributor

@KevinGe00 KevinGe00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change, it's bad practice to bundle dependencies without relocating them and we've already seen problems with this, so this relocation was needed.

Could you just check that building the project works and add it to the test section? ./mvnw clean install -Dgpg.skip -f core/pom.xml

and also ideally test that Coral builds with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants