Adding table properties to signal replication run state#283
Open
rohitkum2506 wants to merge 3 commits intolinkedin:mainfrom
Open
Adding table properties to signal replication run state#283rohitkum2506 wants to merge 3 commits intolinkedin:mainfrom
rohitkum2506 wants to merge 3 commits intolinkedin:mainfrom
Conversation
autumnust
reviewed
Jan 30, 2025
| public final class InternalRepositoryUtils { | ||
|
|
||
| protected static final String POLICIES_KEY = "policies"; | ||
| protected static final String REPLICATION_SETUP_KEY = "replication.enableSetup"; |
Contributor
There was a problem hiding this comment.
I believe this is a leakage of implementation details to expose such internal state as table properties, not to mention the table table properties itself can be lost / modified by users directly. We can certainly make this a preserved key to defend against that argument, but I believe this is the wrong step to start to begin with.
Let's iterate on slack about what is the problem trying to solve here and understand that better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding a property in tblProperties to indicate replication run state for a table based on replicationConfig addition/update.
Property: replication.enableSetup
Cases:
truetrueBased on boolean value of the property, replication job is triggered only when needed, ie. when policy is added or updated.
Changes
For all the boxes checked, please include additional details of the changes made in this pull request.
Testing Done
Unit tests added.
Local Docker system tests:
1: Created table without replication config -> Observed tblProperty is not set
2. Created table without replication config -> tblProperty is set to true
3. Updated tblProperty to false
4. Updated replication config -> tblProperty Replication.enableSetup was set to true
5. Added other table policies -> no effect on tblProperty Replication.enableSetup
For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.
Additional Information
For all the boxes checked, include additional details of the changes made in this pull request.