Skip to content

Job scheduler fixes related to global timeout and status check #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −17
Open

Job scheduler fixes related to global timeout and status check #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 21 additions & 17 deletions apps/spark/src/main/java/com/linkedin/openhouse/jobs/scheduler/tasks/OperationTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,25 +140,26 @@ private Optional<JobState> submitJob(Attributes typeAttributes) {

private Optional<JobState> pollJobStatus(Attributes typeAttributes) {
long startTime = System.currentTimeMillis();
while (!jobFinished()) {
long elapsedTime = System.currentTimeMillis() - startTime;
if (elapsedTime > timeoutMs) {
Optional<JobState> job = jobsClient.getState(jobId);
// Do not cancel job if it is still in running state after 3 hours
if (job.isPresent() && !job.get().equals(JobState.RUNNING)) {
log.info(
"Cancelling job: {} due to timeout for {}: jobState: {}",
getType(),
metadata,
job.get());
if (!jobsClient.cancelJob(jobId)) {
log.error("Could not cancel job {} for {}", getType(), metadata);
return Optional.empty();
while (!Thread.currentThread().isInterrupted() && !jobFinished()) {
try {
long elapsedTime = System.currentTimeMillis() - startTime;
if (elapsedTime > timeoutMs) {
Optional<JobState> job = jobsClient.getState(jobId);
// Do not cancel job if it is still in running state after 3 hours
if (job.isPresent() && !job.get().equals(JobState.RUNNING)) {
log.info(
"Cancelling job: {} due to timeout for {}: jobState: {}",
getType(),
metadata,
job.get());
if (!jobsClient.cancelJob(jobId)) {
log.error("Could not cancel job {} for {}", getType(), metadata);
return Optional.empty();
}
break;
}
break;
}
}
try {
// Sleep for specified poll interval
Thread.sleep(pollIntervalMs);
} catch (InterruptedException e) {
log.warn(
Expand All @@ -170,6 +171,9 @@ private Optional<JobState> pollJobStatus(Attributes typeAttributes) {
log.error("Could not cancel job {} for {}", getType(), metadata);
return Optional.empty();
}
// Interrupt the current thread and exit the loop
Thread.currentThread().interrupt();
break;
}
}
Optional<JobResponseBody> ret = jobsClient.getJob(jobId);
Expand Down
Loading