Factor out business logic of shiv command to facility direct use in python scripts.
#243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commands.py for click setup. I've added a motivating example to the docs for using shiv main() routine direcly from build scripts written in python.
Contributor
Author
|
docs check failing due to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm moving to shiv from a home-grown zipfile packaging script. Really enjoy the simplicity and control of this project, but wanted a way to reuse the logic in main() of cli.py without launching a sub-process or unwrapping the decorations made by click.
This PR factors out the the console commands into its own module and leaves main() as a regular function in cli.py.
python -m shivandpython -m shiv.clishould still reference the click command.Users may find their scripts breaking if they depended directly on
shiv.cli.main, but I see it's been left out of the Shiv API in the documentation. Do let me know if it's a desire to keep main() functionally unchanged (or if the change should be mentioned in the docs) and I'll work around that.Tests passing on my machine and API docs updated.
Best,
Amund