Skip to content

Fix Windows build compatibility issues #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Windows build compatibility issues #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...udfs-compile-utils/src/main/java/com/linkedin/transport/compile/TransportUDFMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,11 @@ public Collection<String> getStdUDFImplementations(String topLevelClass) {
return _udfs.get(topLevelClass);
}

public void toJson(Writer writer) {
GSON.toJson(TransportUDFMetadataSerDe.fromUDFMetadata(this), writer);
public void toJson(Writer writer) throws IOException {
String json = GSON.toJson(TransportUDFMetadataSerDe.fromUDFMetadata(this));
// Gson uses \n for newlines, but on Windows we need \r\n to match test expectations
String jsonWithSystemLineSeparator = json.replace("\n", System.lineSeparator());
writer.write(jsonWithSystemLineSeparator);
}

public static TransportUDFMetadata fromJsonFile(File jsonFile) {
Expand Down
10 changes: 9 additions & 1 deletion ...ble-udfs-trino-plugin/src/test/java/com/linkedin/transport/trino/TransportPluginTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,17 @@


public class TransportPluginTest {
private final String udfRepoDir = getClass().getClassLoader().getResource("transport-udf-repo").getPath();
private final String udfRepoDir;
private LocalQueryRunner queryRunner;

public TransportPluginTest() {
try {
udfRepoDir = java.nio.file.Paths.get(getClass().getClassLoader().getResource("transport-udf-repo").toURI()).toString();
} catch (Exception e) {
throw new RuntimeException("Failed to resolve transport-udf-repo path", e);
}
}

@BeforeClass
public void setUp() {
SqlPath sqlPath = new SqlPath("LINKEDIN.transport");
Expand Down
18 changes: 13 additions & 5 deletions transportable-udfs-utils/src/test/java/com/linkedin/transport/utils/FileSystemUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,26 @@ public class FileSystemUtilsTest {

@Test
public void testResolveLatest() throws IOException, URISyntaxException {
String resourcePath = "file://" + getPathForResource("root");
// Use proper file URI format: file:/// for local files
String resourcePath = java.nio.file.Paths.get(getPathForResource("root")).toUri().toString().replaceAll("/$", "");

// Test cases to resolve #LATEST
// Normalize paths for cross-platform compatibility by replacing backslashes with forward slashes
String filePath = FileSystemUtils.resolveLatest(resourcePath + "/2018/11/02.dat");
Assert.assertTrue(
FileSystemUtils.resolveLatest(resourcePath + "/2018/11/02.dat").endsWith("/root/2018/11/02.dat"));
normalizePath(FileSystemUtils.resolveLatest(resourcePath + "/2018/11/02.dat")).endsWith("/root/2018/11/02.dat"),
"Expected path to end with /root/2018/11/02.dat but was: " + normalizePath(FileSystemUtils.resolveLatest(resourcePath + "/2018/11/02.dat")));
Assert.assertTrue(
FileSystemUtils.resolveLatest(resourcePath + "/#LATEST/11/#LATEST").endsWith("/root/2019/11/02.dat"));
normalizePath(FileSystemUtils.resolveLatest(resourcePath + "/#LATEST/11/#LATEST")).endsWith("/root/2019/11/02.dat"));
Assert.assertTrue(
FileSystemUtils.resolveLatest(resourcePath + "/#LATEST/#LATEST/#LATEST").endsWith("/root/2019/12/02.dat"));
normalizePath(FileSystemUtils.resolveLatest(resourcePath + "/#LATEST/#LATEST/#LATEST")).endsWith("/root/2019/12/02.dat"));
Assert.assertTrue(
FileSystemUtils.resolveLatest(resourcePath + "/#LATEST/#LATEST").endsWith("/root/2019/13.dat"));
normalizePath(FileSystemUtils.resolveLatest(resourcePath + "/#LATEST/#LATEST")).endsWith("/root/2019/13.dat"));
}

private String normalizePath(String path) {
// Replace backslashes with forward slashes for consistent path comparison
return path.replace('\\', '/');
}

private String getPathForResource(String resource) throws URISyntaxException {
Expand Down