-
Notifications
You must be signed in to change notification settings - Fork 100
[vpj] Prevent regular batch push when there are TTL re-pushes #1949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clients/venice-push-job/src/main/java/com/linkedin/venice/hadoop/VenicePushJob.java
Show resolved
Hide resolved
clients/venice-push-job/src/main/java/com/linkedin/venice/hadoop/VenicePushJob.java
Outdated
Show resolved
Hide resolved
gaojieliu
reviewed
Jul 23, 2025
clients/venice-push-job/src/main/java/com/linkedin/venice/hadoop/VenicePushJob.java
Show resolved
Hide resolved
clients/venice-push-job/src/main/java/com/linkedin/venice/hadoop/VenicePushJob.java
Outdated
Show resolved
Hide resolved
e16b442
to
0fe808b
Compare
gaojieliu
reviewed
Jul 30, 2025
services/venice-controller/src/main/java/com/linkedin/venice/controller/VeniceHelixAdmin.java
Show resolved
Hide resolved
gaojieliu
reviewed
Jul 30, 2025
services/venice-controller/src/main/java/com/linkedin/venice/controller/VeniceHelixAdmin.java
Show resolved
Hide resolved
Problem: regular batch push and TTL re-push today are incompatible features. This is because regular batch push will wipe out the RMD needed to perform TTL re-push. Solution: best effort approach to prevent regular batch push when we detect existence of TTL re-push. It's best effort because we only scan through existing versions to see if TTL re-pushes are enabled for the store. It should cover most cases since we are querying the parent controller which has info for the past 5 versions instead of 2. We allow incremental push, re-push and empty pushes to go through. Users can also override this check via VPJ property allow.regular.push.with.ttl.repush.
In addition, make sure batch push with provided record level timestamps are allowed with TTL re-push enabled stores.
0fe808b
to
9e5ff14
Compare
gaojieliu
approved these changes
Jul 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Regular batch push and TTL re-push today are incompatible features. This is because regular batch push will wipe out the RMD needed to perform TTL re-push.
Solution
Added a new self-managed
storeProperties.ttlRepushEnabled
property to signal ttl-repush is enabled for a given store. The property is set to true once a TTL re-push is attempted for a store. Once the property is set to true we will disallow regular batch push.We allow incremental push, re-push, empty pushes and batch push with record level timestamp to go through. Users can also override this check via VPJ property allow.regular.push.with.ttl.repush.
Code changes
Concurrency-Specific Checks
Both reviewer and PR author to verify
synchronized
,RWLock
) are used where needed.ConcurrentHashMap
,CopyOnWriteArrayList
).How was this PR tested?
New integration test and unit test
Does this PR introduce any user-facing or breaking changes?