[controller][admin-tool] Add lookback time parameter to GetDeadStores API #1971
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
The current GetDeadStores API lacks the ability to specify a time window for dead store detection. In cases where the lookback window needs to be reduced such that the the store is considered dead recently but would have been considered NOT dead in the full lookback window.
Solution
Added an optional lookBackMS parameter to the GetDeadStores API using method overloading to maintain full backwards compatibility. The solution propagates this parameter through the entire stack:
Performance considerations: Zero overhead for existing calls as they use the original 3-parameter method. New 4-parameter method only incurs cost when explicitly used.
Testing: All Java compilation passes, method overloading maintains backwards compatibility.
Code changes
Concurrency-Specific Checks
Both reviewer and PR author to verify
How was this PR tested?
Does this PR introduce any user-facing or breaking changes?
"