[server][dvc][cdc] Fix PubSubPosition serialization helper to include typeId #1978
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PubSubPosition serialization to include both typeId and value payload
Previously, only the raw bytes of the position were being serialized, omitting the type ID
and producing an incomplete PubSubPositionWireFormat. This caused deserialization failures
when attempting to reconstruct the full position.
This change ensures that the full PubSubPositionWireFormat—including the type ID and raw
bytes—is serialized and used consistently during conversion.
Code changes
Concurrency-Specific Checks
Both reviewer and PR author to verify
synchronized
,RWLock
) are used where needed.ConcurrentHashMap
,CopyOnWriteArrayList
).How was this PR tested?
Does this PR introduce any user-facing or breaking changes?