[server][dvc][cdc] Fix PubSubPosition serialization helper to include typeId#1978
Merged
sushantmane merged 2 commits intolinkedin:mainfrom Jul 31, 2025
Merged
Conversation
Previously, only the raw bytes of the position were being serialized, omitting the type ID and producing an incomplete PubSubPositionWireFormat. This caused deserialization failures when attempting to reconstruct the full position. This change ensures that the full PubSubPositionWireFormat—including the type ID and raw bytes—is serialized and used consistently during conversion.
sushantmane
force-pushed
the
li-fix-bug-in-position-wire-format-ser
branch
from
33061f3 to
e9bda9a
Compare
sushantmane
changed the title
sixpluszero
reviewed
Jul 31, 2025
internal/venice-common/src/main/java/com/linkedin/venice/pubsub/PubSubPositionDeserializer.java
Outdated
Show resolved
Hide resolved
sixpluszero
approved these changes
Jul 31, 2025
Contributor
sixpluszero
left a comment
sixpluszero
left a comment
There was a problem hiding this comment.
lgtm. Thank you for the quick fix!
Contributor
Author
|
Thanks a lot, @sixpluszero! |
arjun4084346
pushed a commit
to arjun4084346/venice
that referenced
this pull request
Dec 9, 2025
… typeId (linkedin#1978) Previously, only the raw bytes of the position were being serialized, omitting the type ID and producing an incomplete PubSubPositionWireFormat. This caused deserialization failures when attempting to reconstruct the full position. This change ensures that the full PubSubPositionWireFormat—including the type ID and raw bytes—is serialized and used consistently during conversion.
misyel
pushed a commit
to misyel/venice
that referenced
this pull request
Feb 2, 2026
… typeId (linkedin#1978) Previously, only the raw bytes of the position were being serialized, omitting the type ID and producing an incomplete PubSubPositionWireFormat. This caused deserialization failures when attempting to reconstruct the full position. This change ensures that the full PubSubPositionWireFormat—including the type ID and raw bytes—is serialized and used consistently during conversion.
misyel
pushed a commit
to misyel/venice
that referenced
this pull request
Feb 17, 2026
… typeId (linkedin#1978) Previously, only the raw bytes of the position were being serialized, omitting the type ID and producing an incomplete PubSubPositionWireFormat. This caused deserialization failures when attempting to reconstruct the full position. This change ensures that the full PubSubPositionWireFormat—including the type ID and raw bytes—is serialized and used consistently during conversion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix PubSubPosition serialization to include both typeId and value payload
Previously, only the raw bytes of the position were being serialized, omitting the type ID
and producing an incomplete PubSubPositionWireFormat. This caused deserialization failures
when attempting to reconstruct the full position.
This change ensures that the full PubSubPositionWireFormat—including the type ID and raw
bytes—is serialized and used consistently during conversion.
Code changes
Concurrency-Specific Checks
Both reviewer and PR author to verify
synchronized,RWLock) are used where needed.ConcurrentHashMap,CopyOnWriteArrayList).How was this PR tested?
Does this PR introduce any user-facing or breaking changes?