Skip to content

Conversation

@minhmo1620
Copy link
Contributor

Problem Statement

Moving AdminOperation schemas from Venice-controller to Venice-common. We need this change to setup the schema system store for AdminOperation.

Solution

This change should not break anything and it is backward compatible. However, to be safe, we will break it down into smaller chunks.

  1. Duplicate the schemas from Venice-controller to Venice-common (this PR). This needs to be on its own due to line limitations.
  2. Compat change to change protocol definition to point to the new schemas.
  3. Remove the schemas in Venice-controller.

Code changes

  • Added new code behind a config. If so list the config names and their default values in the PR description.
  • Introduced new log lines.
    • Confirmed if logs need to be rate limited to avoid excessive logging.

Concurrency-Specific Checks

Both reviewer and PR author to verify

  • Code has no race conditions or thread safety issues.
  • Proper synchronization mechanisms (e.g., synchronized, RWLock) are used where needed.
  • No blocking calls inside critical sections that could lead to deadlocks or performance degradation.
  • Verified thread-safe collections are used (e.g., ConcurrentHashMap, CopyOnWriteArrayList).
  • Validated proper exception handling in multi-threaded code to avoid silent thread termination.

How was this PR tested?

  • New unit tests added.
  • New integration tests added.
  • Modified or extended existing tests.
  • Verified backward compatibility (if applicable).

Does this PR introduce any user-facing or breaking changes?

  • No. You can skip the rest of this section.
  • Yes. Clearly explain the behavior change and its impact.

@minhmo1620 minhmo1620 marked this pull request as ready for review October 23, 2025 17:34
@minhmo1620 minhmo1620 changed the title [controller][common][protocol] Duplicate AdminOperations schema from venice-controller to venice-common [controller][common][protocol] VALIDATION_OVERRIDE - Duplicate AdminOperations schema from venice-controller to venice-common Oct 23, 2025
@@ -0,0 +1,142 @@
{
"name": "AdminOperation",
"namespace": "com.linkedin.venice.controller.kafka.protocol.admin",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The namespace can be tricky. Can we have some local testing to make sure thing will work or compatible after the move?

@github-actions
Copy link

Hi there. This pull request has been inactive for 30 days. To keep our review queue healthy, we plan to close it in 7 days unless there is new activity. If you are still working on this, please push a commit, leave a comment, or convert it to draft to signal intent. Thank you for your time and contributions.

@github-actions github-actions bot added the stale label Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants