Skip to content

[venice-common] Add VeniceComponent to the PubSubAdminAdapterContext #2282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[venice-common] Add VeniceComponent to the PubSubAdminAdapterContext #2282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ...nal/venice-common/src/main/java/com/linkedin/venice/pubsub/PubSubAdminAdapterContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.linkedin.venice.pubsub;

import com.linkedin.venice.acl.VeniceComponent;
import com.linkedin.venice.pubsub.api.PubSubSecurityProtocol;
import com.linkedin.venice.utils.VeniceProperties;
import io.tehuti.metrics.MetricsRepository;
Expand All @@ -13,6 +14,7 @@ public class PubSubAdminAdapterContext {
private final PubSubPositionTypeRegistry pubSubPositionTypeRegistry;
private final PubSubSecurityProtocol pubSubSecurityProtocol;
private final MetricsRepository metricsRepository;
private final VeniceComponent veniceComponent;

private PubSubAdminAdapterContext(Builder builder) {
this.pubSubBrokerAddress = builder.pubSubBrokerAddress;
Expand All @@ -22,6 +24,7 @@ private PubSubAdminAdapterContext(Builder builder) {
this.pubSubSecurityProtocol = builder.pubSubSecurityProtocol;
this.metricsRepository = builder.metricsRepository;
this.pubSubPositionTypeRegistry = builder.pubSubPositionTypeRegistry;
this.veniceComponent = builder.veniceComponent;
}

public String getPubSubBrokerAddress() {
Expand Down Expand Up @@ -52,6 +55,10 @@ public PubSubPositionTypeRegistry getPubSubPositionTypeRegistry() {
return pubSubPositionTypeRegistry;
}

public VeniceComponent getVeniceComponent() {
return veniceComponent;
}

public static class Builder {
private String pubSubBrokerAddress;
private String adminClientName;
Expand All @@ -60,6 +67,7 @@ public static class Builder {
private PubSubTopicRepository pubSubTopicRepository;
private PubSubPositionTypeRegistry pubSubPositionTypeRegistry;
private MetricsRepository metricsRepository;
private VeniceComponent veniceComponent = VeniceComponent.UNSPECIFIED; // Default component

public Builder setPubSubBrokerAddress(String pubSubBrokerAddress) {
this.pubSubBrokerAddress = pubSubBrokerAddress;
Expand Down Expand Up @@ -96,6 +104,11 @@ public Builder setPubSubPositionTypeRegistry(PubSubPositionTypeRegistry pubSubPo
return this;
}

public Builder setVeniceComponent(VeniceComponent veniceComponent) {
this.veniceComponent = veniceComponent;
return this;
}

public PubSubAdminAdapterContext build() {
if (veniceProperties == null) {
throw new IllegalArgumentException("Missing required properties. Please specify the properties.");
Expand Down
1 change: 1 addition & 0 deletions internal/venice-common/src/main/java/com/linkedin/venice/pubsub/manager/TopicManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ public TopicManager(String pubSubClusterAddress, TopicManagerContext context) {
.setMetricsRepository(context.getMetricsRepository())
.setVeniceProperties(context.getPubSubProperties(pubSubClusterAddress))
.setAdminClientName("TopicManager")
.setVeniceComponent(context.getVeniceComponent())
.build());
this.topicMetadataFetcher = new TopicMetadataFetcher(pubSubClusterAddress, context, stats, pubSubAdminAdapter);
this.logger.info(
Expand Down
Loading