Skip to content

[all] Include PubSubMessageHeaders size in ImmutablePubSubMessage heap size estimation #2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[all] Include PubSubMessageHeaders size in ImmutablePubSubMessage heap size estimation #2287

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af98823
[all] Include PubSubMessageHeaders size in ImmutablePubSubMessage hea…
lluwm Nov 14, 2025
4f9a823
increase buffercapacity in test
lluwm Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion internal/venice-common/src/main/java/com/linkedin/venice/pubsub/ImmutablePubSubMessage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ public String toString() {
public int getHeapSize() {
/** The {@link #topicPartition} is supposed to be a shared instance, and is therefore ignored. */
return SHALLOW_CLASS_OVERHEAD + InstanceSizeEstimator.getObjectSize(key)
+ InstanceSizeEstimator.getObjectSize(value) + InstanceSizeEstimator.getObjectSize(pubSubPosition);
+ InstanceSizeEstimator.getObjectSize(value) + InstanceSizeEstimator.getObjectSize(pubSubPosition)
+ (pubSubMessageHeaders != null ? InstanceSizeEstimator.getObjectSize(pubSubMessageHeaders) : 0);
}
}
Loading