Skip to content

[controller] Skip the parent VT truncate based on the concurrent push strategy #2305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[controller] Skip the parent VT truncate based on the concurrent push strategy #2305

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bca5663
[controller] Skip the parent VT truncate based on the concurrent push…
Nov 20, 2025
2d57e1c
Move isTruncatingTopicNeeded check to the top level call
Nov 21, 2025
3aa2904
Add comments
Nov 21, 2025
2c4c59d
Revert changes in truncateKafkaTopicInParentFabrics
Nov 21, 2025
5761f87
Fix unit tests
Nov 22, 2025
b49d301
Fix tests
Nov 24, 2025
210920e
Update services/venice-controller/src/main/java/com/linkedin/venice/c…
sofiaz11 Nov 25, 2025
3c6fb03
Update services/venice-controller/src/main/java/com/linkedin/venice/c…
sofiaz11 Nov 25, 2025
a7e2586
Fix comments
Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...ices/venice-controller/src/main/java/com/linkedin/venice/controller/VeniceHelixAdmin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@
import com.linkedin.venice.kafka.protocol.enums.ControlMessageType;
import com.linkedin.venice.meta.BackupStrategy;
import com.linkedin.venice.meta.BufferReplayPolicy;
import com.linkedin.venice.meta.ConcurrentPushDetectionStrategy;
import com.linkedin.venice.meta.DarkClusterConfig;
import com.linkedin.venice.meta.DataReplicationPolicy;
import com.linkedin.venice.meta.ETLStoreConfig;
Expand Down Expand Up @@ -4569,6 +4570,17 @@ private boolean truncateKafkaTopicInParentFabrics(String kafkaTopicName) {
boolean allTopicsAreDeleted = true;
Set<String> parentFabrics = multiClusterConfigs.getParentFabrics();
for (String parentFabric: parentFabrics) {
ConcurrentPushDetectionStrategy concurrentPushDetectionStrategy =
multiClusterConfigs.getControllerConfig(parentFabric).getConcurrentPushDetectionStrategy();
if (!concurrentPushDetectionStrategy.isTopicWriteNeeded()) {
LOGGER.info(
"Skipping truncation of topic: {} in parent fabric: {} since the topic was not created there due to"
+ "concurrent push detection strategy: {}",
kafkaTopicName,
parentFabric,
concurrentPushDetectionStrategy.name());
continue;
}
String kafkaBootstrapServerAddress = getPubSubBootstrapServersForRegion(parentFabric);
allTopicsAreDeleted &= truncateKafkaTopic(
getTopicManager(kafkaBootstrapServerAddress),
Expand Down
Loading