[LIZK-3903] Optimizing snapshot creation #125
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| public void takeSnapshot(boolean syncSnap) { | ||
| public void takeSnapshot(boolean syncSnap, boolean isLeaderBootupSnapshot) { |
There was a problem hiding this comment.
Also, add a config to determine whether parallel serialization is enabled. In case not it should use regular snapshot mechanism
Author
There was a problem hiding this comment.
+1, parallel serilazation will be config driven, along with the number of threads.
| */ | ||
| public void serializeSnapshot(OutputArchive oa) throws IOException, InterruptedException { | ||
| SerializeUtils.serializeSnapshot(getDataTree(), oa, getSessionWithTimeOuts()); | ||
| SerializeUtils.serializeSnapshot(getDataTree(), oa, getSessionWithTimeOuts(), false); |
There was a problem hiding this comment.
Let's separate API changes to a separate PR. We can have core snapshot changes in this PR
Author
There was a problem hiding this comment.
If you want to check just the logic change, you can checkout the older commit - d6474f8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is currently WIP, only meant for reviewing code. Unit testing, integration testing and code quality improvements are pending.
Description
This PR adds the logic to optimize the snapshot creation process in zookeeper to enable faster leader switches.
Tests
WIP