chore(validator): enable signal handling for Windows #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zahari Dichev <[email protected]>
alpeb
approved these changes
Jun 12, 2025
validator/src/main.rs
Outdated
| } | ||
| _ = sigterm.recv() => { | ||
| error!("Killed by SIGTERM"); | ||
| // Signal handling |
There was a problem hiding this comment.
Nit: are these two comments supposed to go together?
Signed-off-by: Zahari Dichev <[email protected]>
@alpeb not sure I get that. tracing::error! just logs an error. It does not terminate the program. Am I getting that wrong? |
My bad, you're right! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the signal handling in the network validator in order to enable it to run on Windows
Signed-off-by: Zahari Dichev [email protected]