fix(cli): enable help output by explicitly enabling clap's help feature #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icitly
- In clap v4, the feature system was restructured to be fully granular
- With default-features = false, **no features** are enabled, including help
- Previously in v3, help output was always included by default
- Without explicitly enabling the help feature, running:
./linkerd-network-validator --help
results in:
error: unexpected argument found
- This commit adds the help feature back to enable standard CLI help text
Ref: https://github.com/clap-rs/clap/blob/master/CHANGELOG.md#400---2022-09-28
Signed-off-by: Debasish Biswas <[email protected]>
debasishbsws
added a commit
to wolfi-dev/os
that referenced
this pull request
Jul 2, 2025
linkerd/linkerd2-proxy-init#540 Signed-off-by: Debasish Biswas <[email protected]>
cratelyn
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default-features = false, no features are enabled, including helphelpfeature, running:./linkerd-network-validator --helpresults in:error: unexpected argument foundhelpfeature back to enable standard CLI help textRef: https://github.com/clap-rs/clap/blob/master/CHANGELOG.md#400---2022-09-28