- 
                Notifications
    
You must be signed in to change notification settings  - Fork 284
 
feat: instrument HTTP protocol detection metrics #3722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    154ef43    to
    8d304d3      
    Compare
  
    7c3303d    to
    7958e33      
    Compare
  
    7958e33    to
    52b23d3      
    Compare
  
    This change updates the DetectHttp middleware to record metrics about HTTP protocol detection. Specfically, it records the the counts of results and a very coarse histogram of the time taken to detect the protocol. The inbound, outbound, and admin (via inbound) stacks are updated to record metrics against the main registry.
52b23d3    to
    05c1850      
    Compare
  
    
              
                    cratelyn
  
              
              reviewed
              
                  
                    Mar 10, 2025 
                  
              
              
            
            
              
                    cratelyn
  
              
              reviewed
              
                  
                    Mar 10, 2025 
                  
              
              
            
            
              
                    cratelyn
  
              
              reviewed
              
                  
                    Mar 10, 2025 
                  
              
              
            
            
              
                    cratelyn
  
              
              reviewed
              
                  
                    Mar 10, 2025 
                  
              
              
            
            
              
                    cratelyn
  
              
              reviewed
              
                  
                    Mar 10, 2025 
                  
              
              
            
            
              
                    cratelyn
  
              
              reviewed
              
                  
                    Mar 10, 2025 
                  
              
              
            
            
              
                    cratelyn
  
              
              reviewed
              
                  
                    Mar 10, 2025 
                  
              
              
            
            
              
                    cratelyn
  
              
              approved these changes
              
                  
                    Mar 10, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💐 ✨ nice! i am very excited for how helpful these new metrics will be in debugging various issues related to protocol detection. this will be a great step forward in our observability story, on that front.
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This change updates the DetectHttp middleware to record metrics about HTTP
protocol detection. Specfically, it records the the counts of results and a very
coarse histogram of the time taken to detect the protocol.
The inbound, outbound, and admin (via inbound) stacks are updated to record
metrics against the main registry.
Example metrics