Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid disk resize during Linode creation #216

Closed
wants to merge 48 commits into from
Closed

Avoid disk resize during Linode creation #216

wants to merge 48 commits into from

Conversation

bcm820
Copy link
Contributor

@bcm820 bcm820 commented Mar 25, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 86.23853% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 55.52%. Comparing base (4210732) to head (ed69da7).

Files Patch % Lines
controller/linodemachine_controller.go 86.23% 8 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
+ Coverage   53.83%   55.52%   +1.69%     
==========================================
  Files          27       27              
  Lines        1566     1547      -19     
==========================================
+ Hits          843      859      +16     
+ Misses        673      649      -24     
+ Partials       50       39      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AshleyDumaine AshleyDumaine self-requested a review March 26, 2024 13:49
@bcm820 bcm820 marked this pull request as ready for review March 26, 2024 21:49
AshleyDumaine
AshleyDumaine previously approved these changes Apr 2, 2024
@bcm820 bcm820 closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants