Skip to content

[fix] create scope with default credentials for all resources #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 23, 2024

Merge remote-tracking branch 'origin/main' into updating-scope

6fb60e2
Select commit
Loading
Failed to load commit list.
Merged

[fix] create scope with default credentials for all resources #507

Merge remote-tracking branch 'origin/main' into updating-scope
6fb60e2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 20, 2024 in 0s

65.24% (-0.31%) compared to 17568b5

View this Pull Request on Codecov

65.24% (-0.31%) compared to 17568b5

Details

Codecov Report

Attention: Patch coverage is 70.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 65.24%. Comparing base (17568b5) to head (6fb60e2).

Files with missing lines Patch % Lines
controller/linodemachine_controller.go 0.00% 3 Missing and 1 partial ⚠️
controller/linodecluster_controller.go 0.00% 2 Missing and 1 partial ⚠️
controller/linodefirewall_controller.go 0.00% 2 Missing and 1 partial ⚠️
controller/linodeobjectstoragekey_controller.go 0.00% 2 Missing and 1 partial ⚠️
controller/linodeplacementgroup_controller.go 0.00% 2 Missing and 1 partial ⚠️
controller/linodevpc_controller.go 0.00% 2 Missing and 1 partial ⚠️
cloud/scope/cluster.go 91.66% 1 Missing ⚠️
cloud/scope/firewall.go 87.50% 1 Missing ⚠️
cloud/scope/object_storage_key.go 87.50% 1 Missing ⚠️
cloud/scope/placement_group.go 87.50% 1 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
- Coverage   65.55%   65.24%   -0.31%     
==========================================
  Files          77       77              
  Lines        4003     4037      +34     
==========================================
+ Hits         2624     2634      +10     
- Misses       1143     1161      +18     
- Partials      236      242       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov